fix(pl): reject unknown plan product ids on upsert with 422.
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
1 parent
857067ec80
commit
2e5b05f477
3 files changed
+74
-5
No files matched your search
@@ -1,7 +1,15 @@
|
||||
"""build_plan_product 应支持传入 product_row_id,编辑时保持 pl_plan_product.id 稳定。"""
|
||||
"""build_plan_product / upsert 应保持 id 稳定,并拒绝外键无效的产品行 id。"""
|
||||
from unittest.mock import MagicMock
|
||||
|
||||
import pytest
|
||||
from fastapi import HTTPException
|
||||
|
||||
from app.schemas.pl.plan import PlanProductCreate
|
||||
from app.services import pl_plan_service as svc
|
||||
from app.services.pl_plan_service import build_plan_product
|
||||
from app.services.pl_plan_service import (
|
||||
build_plan_product,
|
||||
resolve_plan_product_id_for_upsert,
|
||||
)
|
||||
|
||||
|
||||
def _minimal_prod(**kwargs) -> PlanProductCreate:
|
||||
@@ -40,3 +48,37 @@ def test_build_plan_product_generates_when_missing(monkeypatch):
|
||||
dept_id="d1",
|
||||
)
|
||||
assert result.id == "gen-1"
|
||||
|
||||
|
||||
def test_upsert_plan_product_rejects_foreign_id():
|
||||
with pytest.raises(HTTPException) as ei:
|
||||
resolve_plan_product_id_for_upsert(
|
||||
plan_id="plan-1",
|
||||
payload_id="pp-other-plan",
|
||||
existing_by_id={},
|
||||
)
|
||||
assert ei.value.status_code == 422
|
||||
|
||||
|
||||
def test_upsert_plan_product_keeps_payload_id():
|
||||
existing = MagicMock()
|
||||
existing.id = "pp-keep"
|
||||
existing.plan_id = "plan-1"
|
||||
row_id, row = resolve_plan_product_id_for_upsert(
|
||||
plan_id="plan-1",
|
||||
payload_id="pp-keep",
|
||||
existing_by_id={"pp-keep": existing},
|
||||
)
|
||||
assert row_id == "pp-keep"
|
||||
assert row is existing
|
||||
|
||||
|
||||
def test_upsert_plan_product_generates_when_missing(monkeypatch):
|
||||
monkeypatch.setattr(svc, "generate_uuid", lambda: "new-pp")
|
||||
row_id, row = resolve_plan_product_id_for_upsert(
|
||||
plan_id="plan-1",
|
||||
payload_id=None,
|
||||
existing_by_id={},
|
||||
)
|
||||
assert row_id == "new-pp"
|
||||
assert row is None
|
||||
Reference in new issue
Block a user