fix(web): limit protocol managers to active region leaders

Provide tenant-scoped leader options for the Web protocol form, exclude ordinary members and retain historical names only for display. Default only to a leader of the selected region and prevent delayed requests from replacing manual choices.

Refs #1. Add backend option isolation and Web cascade regression coverage.

web-admin/src/api/collection-protocol.ts

@@ -27,6 +27,14 @@ export function fetchCollectionProtocolList(params?: {
   })
 }
 
+export type ProtocolRegionManager = { id: string; nickName: string; regionIds: string[] }
+
+export function fetchProtocolRegionManagers() {
+  return request.get<{ list: ProtocolRegionManager[] }>({
+    url: '/web/admin/collection-protocols/region-managers'
+  })
+}
+
 export function fetchCollectionProtocolDetail(id: string) {
   return request.get<{
     protocol: Record<string, unknown>

web-admin/src/utils/protocol-region-managers.test.ts

@@ -0,0 +1,166 @@
+import assert from 'node:assert/strict'
+import { readFileSync } from 'node:fs'
+import test from 'node:test'
+import ts from 'typescript'
+
+const source = readFileSync(
+  new URL('../views/cell-storage/protocol/ProtocolFormDialog.vue', import.meta.url),
+  'utf8'
+)
+function method(name: string) {
+  const asyncStart = source.indexOf(`  async function ${name}(`)
+  const start = asyncStart >= 0 ? asyncStart : source.indexOf(`  function ${name}(`)
+  const end = source.indexOf('\n  }', start) + 4
+  return source.slice(start, end)
+}
+function harness() {
+  const requests: Array<{ resolve: (value: any) => void; reject: (error: Error) => void }> = []
+  const hospitals: Array<{ resolve: () => void }> = []
+  const refs = {
+    managerLoading: { value: false },
+    managerUserOptions: { value: [] as any[] },
+    managerSnapshot: { value: null as any },
+    regionManagerUserId: { value: null as string | null },
+    formData: { regionId: 'a', regionManagerUserId: '' }
+  }
+  const deps = {
+    ...refs,
+    linkedRegionMode: { value: false },
+    regionOptions: { value: [] },
+    hospitalOptions: { value: [] },
+    fetchRegionsByStaffUser: async () => ({ list: [{ id: 'b', regionName: 'B区' }] }),
+    loadHospitalsByRegion: () => new Promise<void>((resolve) => hospitals.push({ resolve })),
+    fetchProtocolRegionManagers: () =>
+      new Promise((resolve, reject) => requests.push({ resolve, reject })),
+    fetchUserList: async () => ({ list: [{ id: 'member', nickName: '普通员工' }] }),
+    fetchRegionStaffList: async () => ({
+      list: [{ userId: 'member', nickName: '普通员工', isLeader: false }]
+    }),
+    makeManagerUserStub: (id: string, nickName: string) => ({ id, nickName }),
+    ElMessage: { error: () => {} }
+  }
+  const code = ts.transpileModule(
+    `let managerSearchVersion = 0; let managerDefaultVersion = 0;
+    ${method('remoteSearchManagerUsers')}
+    ${method('applyDefaultRegionManager')}
+    ${method('onManagerUserChange')}
+    ${method('applyRegionsForSalesUser')}
+    return { search: remoteSearchManagerUsers, apply: applyDefaultRegionManager, select: onManagerUserChange, applySales: applyRegionsForSalesUser }`,
+    { compilerOptions: { target: ts.ScriptTarget.ES2022 } }
+  ).outputText
+  return {
+    ...refs,
+    requests,
+    hospitals,
+    ...new Function(...Object.keys(deps), code)(...Object.values(deps))
+  }
+}
+const leaders = [
+  { id: 'head-a', nickName: 'A负责人', regionIds: ['a'] },
+  { id: 'head-b', nickName: 'B负责人', regionIds: ['b'] }
+]
+
+test('manager search uses all region leaders without appending historical ordinary users', async () => {
+  const h = harness()
+  h.regionManagerUserId.value = 'member'
+  h.managerSnapshot.value = { id: 'member', nickName: '历史人员' }
+  const pending = h.search('')
+  h.requests[0]?.resolve({ list: leaders })
+  await pending
+  assert.deepEqual(
+    h.managerUserOptions.value.map((u: any) => u.id),
+    ['head-a', 'head-b']
+  )
+  assert.equal(h.managerSnapshot.value.nickName, '历史人员')
+})
+
+test('a region without a leader stays empty instead of defaulting to an ordinary member', async () => {
+  const h = harness()
+  const pending = h.apply('a')
+  h.requests[0]?.resolve({ list: [leaders[1]] })
+  await pending
+  assert.equal(h.formData.regionManagerUserId, '')
+  assert.equal(h.regionManagerUserId.value, null)
+})
+
+test('default manager belongs to selected region while candidates include all leaders', async () => {
+  const h = harness()
+  const pending = h.apply('a')
+  h.requests[0]?.resolve({ list: leaders })
+  await pending
+  assert.equal(h.formData.regionManagerUserId, 'head-a')
+  assert.deepEqual(
+    h.managerUserOptions.value.map((u: any) => u.id),
+    ['head-a', 'head-b']
+  )
+})
+
+test('clearing a region invalidates pending manager defaults', async () => {
+  const h = harness()
+  const pending = h.apply('a')
+  h.formData.regionId = ''
+  await h.apply('')
+  h.requests[0]?.resolve({ list: leaders })
+  await pending
+  assert.equal(h.formData.regionManagerUserId, '')
+})
+
+test('out-of-order manager searches cannot overwrite the latest result', async () => {
+  const h = harness()
+  const first = h.search('A')
+  const second = h.search('B')
+  h.requests[1]?.resolve({ list: leaders })
+  await second
+  h.requests[0]?.resolve({ list: leaders })
+  await first
+  assert.deepEqual(
+    h.managerUserOptions.value.map((u: any) => u.id),
+    ['head-b']
+  )
+})
+
+test('a manual selection is not overwritten by a pending default response', async () => {
+  const h = harness()
+  const pending = h.apply('a')
+  h.managerUserOptions.value = leaders
+  h.select('head-b')
+  h.requests[0].resolve({ list: leaders })
+  await pending
+  assert.equal(h.formData.regionManagerUserId, 'head-b')
+})
+
+test('failed manager loading clears the old default and never falls back to ordinary users', async () => {
+  const h = harness()
+  h.formData.regionManagerUserId = 'old'
+  h.regionManagerUserId.value = 'old'
+  const pending = h.apply('a')
+  h.requests[0].reject(new Error('network failure'))
+  await pending
+  assert.equal(h.formData.regionManagerUserId, '')
+  assert.deepEqual(h.managerUserOptions.value, [])
+})
+
+test('a delayed default call for an old region cannot clear the current manager', async () => {
+  const h = harness()
+  h.formData.regionId = 'b'
+  h.formData.regionManagerUserId = 'head-b'
+  h.regionManagerUserId.value = 'head-b'
+  const pending = h.apply('a')
+  h.requests[0]?.resolve({ list: leaders })
+  await pending
+  assert.equal(h.formData.regionManagerUserId, 'head-b')
+  assert.equal(h.regionManagerUserId.value, 'head-b')
+})
+
+test('sales-linked region loading does not overwrite a manager chosen while hospitals load', async () => {
+  const h = harness()
+  const pending = h.applySales('sales-b')
+  await Promise.resolve()
+  h.managerUserOptions.value = leaders
+  h.select('head-a')
+  h.hospitals[0].resolve()
+  await Promise.resolve()
+  h.requests[0].resolve({ list: leaders })
+  await pending
+  assert.equal(h.formData.regionManagerUserId, 'head-a')
+})

web-admin/src/views/cell-storage/protocol/ProtocolFormDialog.vue

@@ -154,10 +154,21 @@
                   clearable
                   reserve-keyword
                   :remote-method="remoteSearchManagerUsers"
+                  @visible-change="(visible: boolean) => visible && remoteSearchManagerUsers('')"
                   :loading="managerLoading"
                   placeholder="默认取地区负责人，可修改"
                   @change="onManagerUserChange"
                 >
+                  <el-option
+                    v-if="
+                      managerSnapshot &&
+                      !managerUserOptions.some((u) => u.id === managerSnapshot?.id)
+                    "
+                    v-show="false"
+                    :label="managerSnapshot.nickName"
+                    :value="managerSnapshot.id"
+                    disabled
+                  />
                   <el-option
                     v-for="u in managerUserOptions"
                     :key="u.id"
@@ -1162,6 +1173,7 @@
   } from '@element-plus/icons-vue'
   import {
     fetchCollectionProtocolDetail,
+    fetchProtocolRegionManagers,
     fetchCreateCollectionProtocol,
     fetchUpdateCollectionProtocol,
     fetchSubmitReceiptFinance,
@@ -1188,7 +1200,6 @@
     fetchItemUnitList,
     fetchCollectionRegionList,
     fetchHospitalList,
-    fetchRegionStaffList,
     fetchRegionsByStaffUser,
     fetchSampleCodeList,
     fetchExpressCompanyList,
@@ -1308,7 +1319,9 @@
   const salesSnapshot = ref<Api.User.UserItem | null>(null)
 
   const regionManagerUserId = ref<string | null>(null)
-  const managerUserOptions = ref<Api.User.UserItem[]>([])
+  const managerUserOptions = ref<Array<Api.User.UserItem & { regionIds: string[] }>>([])
+  let managerSearchVersion = 0
+  let managerDefaultVersion = 0
   const managerLoading = ref(false)
   const managerSnapshot = ref<Api.User.UserItem | null>(null)
   const linkedRegionMode = ref(false)
@@ -1607,6 +1620,9 @@
   }
 
   function resetForm() {
+    managerSearchVersion++
+    managerDefaultVersion++
+    managerLoading.value = false
     Object.assign(formData, {
       protocolNo: '',
       protocolNoId: '',
@@ -2729,7 +2745,6 @@
       (user) => {
         managerSnapshot.value = { ...user }
         regionManagerUserId.value = user.id
-        managerUserOptions.value = [{ ...user }]
         formData.regionManagerUserId = user.id
       },
       () => {
@@ -2739,6 +2754,7 @@
         formData.regionManagerUserId = ''
       }
     )
+    await remoteSearchManagerUsers('')
   }
 
   function makeManagerUserStub(id: string, name: string): Api.User.UserItem {
@@ -2974,28 +2990,29 @@
   }
 
   async function remoteSearchManagerUsers(query: string) {
+    const version = ++managerSearchVersion
     managerLoading.value = true
     try {
-      const res = await fetchUserList({
-        page: 1,
-        pageSize: 50,
-        keyword: (query || '').trim() || undefined,
-        status: '1'
-      })
-      let list = [...(res.list || [])]
-      const cur = regionManagerUserId.value
-      if (cur && !list.some((x) => x.id === cur)) {
-        const keep =
-          managerSnapshot.value?.id === cur
-            ? managerSnapshot.value
-            : managerUserOptions.value.find((x) => x.id === cur)
-        if (keep) list = [keep, ...list]
+      const res = await fetchProtocolRegionManagers()
+      const keyword = (query || '').trim().toLowerCase()
+      const list = (res.list || []).map((item) => ({
+        ...makeManagerUserStub(item.id, item.nickName),
+        regionIds: item.regionIds
+      }))
+      if (version === managerSearchVersion) {
+        managerUserOptions.value = list.filter((item) =>
+          item.nickName.toLowerCase().includes(keyword)
+        )
       }
-      managerUserOptions.value = list
+      return list
     } catch {
-      managerUserOptions.value = []
+      if (version === managerSearchVersion) {
+        managerUserOptions.value = []
+        ElMessage.error('地区负责人加载失败，请重试')
+      }
+      return []
     } finally {
-      managerLoading.value = false
+      if (version === managerSearchVersion) managerLoading.value = false
     }
   }
 
@@ -3016,53 +3033,34 @@
   }
 
   function onManagerUserChange(val: string | null | undefined) {
+    managerDefaultVersion++
     if (!val) {
       regionManagerUserId.value = null
       managerSnapshot.value = null
       formData.regionManagerUserId = ''
       return
     }
-    const u = managerUserOptions.value.find((x) => x.id === val) || managerSnapshot.value
-    if (!u) {
-      regionManagerUserId.value = val
-      formData.regionManagerUserId = val
-      return
-    }
+    const u = managerUserOptions.value.find((x) => x.id === val)
+    if (!u) return
     managerSnapshot.value = { ...u }
     regionManagerUserId.value = u.id
     formData.regionManagerUserId = u.id
   }
 
   async function applyDefaultRegionManager(regionId: string) {
-    if (!regionId) {
-      regionManagerUserId.value = null
-      formData.regionManagerUserId = ''
-      managerUserOptions.value = []
-      managerSnapshot.value = null
-      return
-    }
-    try {
-      const res: any = await fetchRegionStaffList(regionId, { page: 1, pageSize: 100 })
-      const list = (res?.list || []) as Array<Record<string, any>>
-      const leader = list.find((x) => x.isLeader) || list[0]
-      if (!leader?.userId) {
-        regionManagerUserId.value = null
-        formData.regionManagerUserId = ''
-        return
-      }
-      const stub = makeManagerUserStub(
-        String(leader.userId),
-        String(leader.nickName || leader.userName || '')
-      )
-      regionManagerUserId.value = stub.id
-      formData.regionManagerUserId = stub.id
-      managerSnapshot.value = { ...stub }
-      if (!managerUserOptions.value.some((x) => x.id === stub.id)) {
-        managerUserOptions.value = [stub, ...managerUserOptions.value]
-      }
-    } catch {
-      /* 地区无人员配置时留空，可手工选择 */
-    }
+    if (formData.regionId !== regionId) return
+    const version = ++managerDefaultVersion
+    regionManagerUserId.value = null
+    formData.regionManagerUserId = ''
+    managerSnapshot.value = null
+    if (!regionId) return
+    const list = await remoteSearchManagerUsers('')
+    if (version !== managerDefaultVersion || formData.regionId !== regionId) return
+    const leader = list.find((item) => item.regionIds.includes(regionId))
+    if (!leader) return
+    regionManagerUserId.value = leader.id
+    formData.regionManagerUserId = leader.id
+    managerSnapshot.value = { ...leader }
   }
 
   async function applyRegionsForSalesUser(
@@ -3112,10 +3110,10 @@
         if (regionChanged) {
           formData.hospitalId = ''
           hospitalOptions.value = []
-          await loadHospitalsByRegion(nextId, '')
-          if (!opts?.skipManagerDefault) {
-            await applyDefaultRegionManager(nextId)
-          }
+          await Promise.all([
+            loadHospitalsByRegion(nextId, ''),
+            ...(opts?.skipManagerDefault ? [] : [applyDefaultRegionManager(nextId)])
+          ])
         } else if (!opts?.skipManagerDefault && !formData.regionManagerUserId) {
           await applyDefaultRegionManager(nextId)
         }
@@ -3246,6 +3244,7 @@
   }
 
   async function onRegionChange(val: string | null | undefined) {
+    managerDefaultVersion++
     if (!val) {
       formData.regionId = ''
       hospitalOptions.value = []
@@ -3259,11 +3258,11 @@
     formData.regionId = val
     formData.hospitalId = ''
     hospitalOptions.value = []
-    await loadHospitalsByRegion(val)
-    await applyDefaultRegionManager(val)
+    await Promise.all([loadHospitalsByRegion(val), applyDefaultRegionManager(val)])
   }
 
   function onRegionClear() {
+    managerDefaultVersion++
     formData.regionId = ''
     formData.hospitalId = ''
     hospitalOptions.value = []